Add container for busuanzi counter widget#1154
Merged
stevenjoezhang merged 6 commits intotheme-next:masterfrom Sep 15, 2019
Merged
Add container for busuanzi counter widget#1154stevenjoezhang merged 6 commits intotheme-next:masterfrom
stevenjoezhang merged 6 commits intotheme-next:masterfrom
Conversation
This will hide the `span` until `busuanzi`'s script is correctly loaded.
|
Thanks so much for opening your first PR here! |
|
|
…busuanzi site_pv & site_uv.
Liam0205
force-pushed
the
dev-busuanzi_container
branch
from
3376bb6 to
00cd72e
Compare
ivan-nginx
approved these changes
Sep 6, 2019
ivan-nginx
approved these changes
Sep 6, 2019
stevenjoezhang
changed the title
|
Congrats on merging your first pull request here! 🎉 How awesome! |
Member
|
@all-contributors please add @Liam0205 for code |
Contributor
|
I've put up a pull request to add @Liam0205! 🎉 |
15 tasks
tongluyang
pushed a commit
to tongluyang/hexo-theme-next
that referenced
this pull request
Nov 19, 2019
* [layout] _macro/post.swig: add container to busuanzi page_pv. * [layout] _partials/analytics/busuanzi-counter.swig: add container to busuanzi site_pv & site_uv. This will hide the `span` until `busuanzi`'s script is correctly loaded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue resolved: N/A
For
busuanzicounter, if the script is not correctly loaded and executed, the display would be broken. Example:What is the new behavior?
For
busuanzicounter, if the script is not correctly loaded and executed, the containerspanwill remain hidden, rather than broken display.How to use?
Automatically enable, if
busuanziis enabled.Does this PR introduce a breaking change?